-
Notifications
You must be signed in to change notification settings - Fork 23
feat: Support download from mirrors #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TexBlock
reviewed
Sep 1, 2025
Closed
xfl03
reviewed
Oct 17, 2025
| GameAssetDetail ret = new GameAssetDetail(); | ||
|
|
||
| ret.downloads = convert.convertFrom.stream().map(it -> getAssetMetaData(it, loader)).map(it -> { | ||
| String asset_root = getFastestUrl(); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
驼峰变量名,下同
xfl03
reviewed
Oct 17, 2025
xfl03
requested changes
Oct 17, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
格式问题较多,建议format一下
没别的问题了,改好可以合并了
Contributor
Author
All fixed |
xfl03
reviewed
Oct 17, 2025
Removed commented out localhost mirror URL.
xfl03
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此PR必须在 CFPAOrg/Minecraft-Mod-Language-Package#5523 后才能合并,否则会导致GitHub访问性较好的用户无法正常使用。
计划是这样的……
顺便支持了对葫芦服务器的镜像。