Sonarqube #897
Merged
Sonarqube #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 5cdd61f in 1 minute and 4 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_38EZS1ukuTE6XfGj
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| run: | | ||
| sudo apt update | ||
| sudo apt-get install -y openmpi-bin openmpi-common mpi-default-dev gcov | ||
| sudo apt-get install -y openmpi-bin openmpi-common mpi-default-dev |
There was a problem hiding this comment.
Removing gcov installation may break coverage collection, as -ftest-coverage flags and sonar configuration rely on gcov. Confirm that default gcc provides it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed installing gcov
Important
Remove
gcovinstallation from SonarQube GitHub Actions workflow.gcovfrom the list of installed packages in.github/workflows/sonarqube.yml.This description was created by
for 5cdd61f. You can customize this summary. It will automatically update as commits are pushed.