Make audio.signal package more consistent #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
637092c to
00fd15c
Compare
00fd15c to
827593d
Compare
827593d to
5c2c33a
Compare
added 2 commits
February 17, 2016 20:03
normalize() rescales the signal to have maximum range for the dtype remix() converts to float and back if needed to prevent clipping when down-mixing
1752574 to
050223a
Compare
added 2 commits
February 18, 2016 05:54
frames to left of the first frame can still be accessed with frame_signal()
superbock
pushed a commit
that referenced
this pull request
Feb 18, 2016
Make audio.signal package more consistent
This was referenced Feb 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the inconsistencies of
audio.signalpackage.attofFramedSignalbygainand move everything toSignalattas deprecatedremix()andnormalize()to always return the same dtypenormalize()rescales the signal to have maximum range for the dtype NOTE: this changes the old behaviour!remix()converts to float and back if needed to prevent clipping when down-mixingrescale()can be used to convert a signal with int dtype to float dtype and scale it to the maximum range [-1,1]FramedSignalbehaves like normal Python/Numpy indexing NOTE: this changes the old behaviour!