Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vuorioma
Copy link
Collaborator

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Note if PR is on top of other PR
  • Note if related change in rems-deploy repo
  • Consider adding screenshots for ease of review

Backwards compatibility

  • API is backwards compatible or completely new
  • Events are backwards compatible or have migrations
  • Config is backwards compatible
  • Feature appears correctly in PDF print

Documentation

  • Update changelog if necessary
  • API is documented and shows up in Swagger UI
  • Components are added to guide page
  • Update docs/ (if applicable)
  • Update manual/ (if applicable)
  • ADR for major architectural decisions or experiments
  • New config options in config-defaults.edn

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

  • New tasks are created for pending or remaining tasks

project.clj Outdated

:profiles
{:uberjar {:omit-source true
{:uberjar {:dependencies [[binaryage/devtools "1.0.7"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could put these straight into the top level dependencies along with :project/dev dependencies to avoid multiple sources of truth, since both appear to be identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants