Codestin Search App

keckelt · 2022-10-06T08:52:25Z

Closes https://github.com/Caleydo/cohort/issues/579

Developer Checklist (Definition of Done)

Issue

All acceptance criteria from the issue are met
Tested in latest Chrome/Firefox

UI/UX/Vis

Requires UI/UX/Vis review
- Reviewer(s) are notified (tag assignees)
- Review has occurred (link to notes)
- Feedback is included in this PR
- Reviewer(s) approve of concept and design

Code

Branch is up-to-date with the branch to be merged with, i.e., develop
Code is cleaned up and formatted
Unit tests are written (frontend/backend if applicable)
Integration tests are written (if applicable)

PR

Descriptive title for this pull request is provided (will be used for release notes later)
Reviewer and assignees are defined
Add type label (e.g., bug, feature) to this pull request
Add release label (e.g., release: minor) to this PR following semver
The PR is connected to the corresponding issue (via Closes #...)
Summary of changes is written

Summary of changes

If onboarding tooltip will be shown - i.e. no cookie - than the user has to click the root cohort
If onboarding tolltip is not shown - only on hover - than the root cohort is automatically selected

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

PatrickAdelberger

okay 👍

* Prepare github changes * Remove circleci * Release 3.1.0 (#42) * prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare release 3.1.0 * Update publish.yml Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: anita-steiner <> Co-authored-by: Anita Steiner <[email protected]> * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <[email protected]> * Update fontawesome * Merge visyn_scripts * Release 4.0.0 (#46) * prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <[email protected]> * Update fontawesome * Merge visyn_scripts * prepare release 4.0.0 Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: anita-steiner <> Co-authored-by: Holger Stitz <[email protected]> * prepare next dev version * Merged `d3_changes` into `develop` (#45) * use d3v7 and d3v3 imports remove depenencies to d3 add dependency to tdp_core * remove console log * Dev d3 merge fix (#47) * move RouterScrollToTop to coral_public * fix TS errors * move canvas-confetti to coral_public * update git dependencies Co-authored-by: Klaus Eckelt <[email protected]> * Automatically select root cohort if onboarding was already done (#48) * Autoselect rootcohort if onboarding was done #579 * format code * Remove grid lines from visualizations (#49) remove gridlines #400 * fix type error Co-authored-by: anita-steiner <> Co-authored-by: Vanessa Stoiber <[email protected]> Co-authored-by: Anita Steiner <[email protected]> Co-authored-by: dvvanessastoiber <[email protected]> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]>

* prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <[email protected]> * Update fontawesome * Merge visyn_scripts * prepare next dev version * Merged `d3_changes` into `develop` (#45) * use d3v7 and d3v3 imports remove depenencies to d3 add dependency to tdp_core * remove console log * Dev d3 merge fix (#47) * move RouterScrollToTop to coral_public * fix TS errors * move canvas-confetti to coral_public * update git dependencies Co-authored-by: Klaus Eckelt <[email protected]> * Automatically select root cohort if onboarding was already done (#48) * Autoselect rootcohort if onboarding was done #579 * format code * Remove grid lines from visualizations (#49) remove gridlines #400 * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * prepare release 4.1.0 --------- Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: anita-steiner <> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Michael Pühringer <[email protected]>

* Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * Release 4.1.0 (#54) * prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <[email protected]> * Update fontawesome * Merge visyn_scripts * prepare next dev version * Merged `d3_changes` into `develop` (#45) * use d3v7 and d3v3 imports remove depenencies to d3 add dependency to tdp_core * remove console log * Dev d3 merge fix (#47) * move RouterScrollToTop to coral_public * fix TS errors * move canvas-confetti to coral_public * update git dependencies Co-authored-by: Klaus Eckelt <[email protected]> * Automatically select root cohort if onboarding was already done (#48) * Autoselect rootcohort if onboarding was done #579 * format code * Remove grid lines from visualizations (#49) remove gridlines #400 * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * prepare release 4.1.0 --------- Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: anita-steiner <> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Michael Pühringer <[email protected]> * prepare next dev version * Migration to visyn_core (#55) * Migration to visyn_core * Linting * Upgrade deps --------- Co-authored-by: Michael Puehringer <[email protected]> * Fix cohort * Fix circular dependencies * Further cleanup * Fix async in loop * Import * Add todos for async inside loop errors --------- Co-authored-by: Michael Pühringer <[email protected]> Co-authored-by: Vanessa Stoiber <[email protected]> Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: dvvanessastoiber <[email protected]> Co-authored-by: Michael Puehringer <[email protected]>

* Remove `|| true` to show eslint errors #693 * Run `lint:fix` to automatically fix formatting #693 * Add missing component `RouterScrollToTop` * Refactor src/app.ts into separate files src/app/* Caleydo/cohort#693 * Rename app/Cohort to app/Coral * Move colors to config/colors Caleydo/cohort#693 * Move rest to base/rest Caleydo/cohort#693 * Move ScrollLinker from util file to utils/ScrollLinker Caleydo/cohort#693 * Remove unused color schemes Caleydo/cohort#693 * Extract CohortColorSchema from util to separate file Caleydo/cohort#693 * Merge CohortColorSchema with config/colors Caleydo/cohort#693 * Move utilCustomEvents to base/events Caleydo/cohort#693 * Move utilIdTypes to config/entities Caleydo/cohort#693 * Move utilLabels to utils/labels Caleydo/cohort#693 * Merge Tooltip into AColumn and remove export Caleydo/cohort#693 * Rename event to event2 for nested event Caleydo/cohort#693 * Merge CohortInterfaces into app/interfaces Caleydo/cohort#693 * Use `ICohort` instead `Cohort` Caleydo/cohort#693 - Replace `Cohort` with `ICohort` were possible - Add interfaces `IInputCohort` and `IOutputCohort` - Move classes `InputCohort` and `OutputCohort` to Cohort.ts - Move public functions and properties from `Cohort` to interface `ICohort` - Move interfaces and enums from `Cohort` to app/interfacoes - Replace `Array<...>` with `...[]` syntax * Reorder functions in utlis/labels Caleydo/cohort#693 * Eslint and typescript errors (#56) * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * Release 4.1.0 (#54) * prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <[email protected]> * Update fontawesome * Merge visyn_scripts * prepare next dev version * Merged `d3_changes` into `develop` (#45) * use d3v7 and d3v3 imports remove depenencies to d3 add dependency to tdp_core * remove console log * Dev d3 merge fix (#47) * move RouterScrollToTop to coral_public * fix TS errors * move canvas-confetti to coral_public * update git dependencies Co-authored-by: Klaus Eckelt <[email protected]> * Automatically select root cohort if onboarding was already done (#48) * Autoselect rootcohort if onboarding was done #579 * format code * Remove grid lines from visualizations (#49) remove gridlines #400 * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * prepare release 4.1.0 --------- Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: anita-steiner <> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Michael Pühringer <[email protected]> * prepare next dev version * Migration to visyn_core (#55) * Migration to visyn_core * Linting * Upgrade deps --------- Co-authored-by: Michael Puehringer <[email protected]> * Fix cohort * Fix circular dependencies * Further cleanup * Fix async in loop * Import * Add todos for async inside loop errors --------- Co-authored-by: Michael Pühringer <[email protected]> Co-authored-by: Vanessa Stoiber <[email protected]> Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: dvvanessastoiber <[email protected]> Co-authored-by: Michael Puehringer <[email protected]> * bug: merge data subtype object * Fix client config typings --------- Co-authored-by: Champari Oltion <[email protected]> Co-authored-by: Michael Pühringer <[email protected]> Co-authored-by: Vanessa Stoiber <[email protected]> Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: dvvanessastoiber <[email protected]> Co-authored-by: Michael Puehringer <[email protected]> Co-authored-by: oltionchampari <[email protected]>

* Remove `|| true` to show eslint errors #693 * Run `lint:fix` to automatically fix formatting #693 * Add missing component `RouterScrollToTop` * Refactor src/app.ts into separate files src/app/* Caleydo/cohort#693 * Rename app/Cohort to app/Coral * Move colors to config/colors Caleydo/cohort#693 * Move rest to base/rest Caleydo/cohort#693 * Move ScrollLinker from util file to utils/ScrollLinker Caleydo/cohort#693 * Remove unused color schemes Caleydo/cohort#693 * Extract CohortColorSchema from util to separate file Caleydo/cohort#693 * Merge CohortColorSchema with config/colors Caleydo/cohort#693 * Move utilCustomEvents to base/events Caleydo/cohort#693 * Move utilIdTypes to config/entities Caleydo/cohort#693 * Move utilLabels to utils/labels Caleydo/cohort#693 * Merge Tooltip into AColumn and remove export Caleydo/cohort#693 * Rename event to event2 for nested event Caleydo/cohort#693 * Merge CohortInterfaces into app/interfaces Caleydo/cohort#693 * Use `ICohort` instead `Cohort` Caleydo/cohort#693 - Replace `Cohort` with `ICohort` were possible - Add interfaces `IInputCohort` and `IOutputCohort` - Move classes `InputCohort` and `OutputCohort` to Cohort.ts - Move public functions and properties from `Cohort` to interface `ICohort` - Move interfaces and enums from `Cohort` to app/interfacoes - Replace `Array<...>` with `...[]` syntax * Reorder functions in utlis/labels Caleydo/cohort#693 * Eslint and typescript errors (#56) * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * Release 4.1.0 (#54) * prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <[email protected]> * Update fontawesome * Merge visyn_scripts * prepare next dev version * Merged `d3_changes` into `develop` (#45) * use d3v7 and d3v3 imports remove depenencies to d3 add dependency to tdp_core * remove console log * Dev d3 merge fix (#47) * move RouterScrollToTop to coral_public * fix TS errors * move canvas-confetti to coral_public * update git dependencies Co-authored-by: Klaus Eckelt <[email protected]> * Automatically select root cohort if onboarding was already done (#48) * Autoselect rootcohort if onboarding was done #579 * format code * Remove grid lines from visualizations (#49) remove gridlines #400 * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * prepare release 4.1.0 --------- Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: anita-steiner <> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Michael Pühringer <[email protected]> * prepare next dev version * Migration to visyn_core (#55) * Migration to visyn_core * Linting * Upgrade deps --------- Co-authored-by: Michael Puehringer <[email protected]> * Fix cohort * Fix circular dependencies * Further cleanup * Fix async in loop * Import * Add todos for async inside loop errors --------- Co-authored-by: Michael Pühringer <[email protected]> Co-authored-by: Vanessa Stoiber <[email protected]> Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: dvvanessastoiber <[email protected]> Co-authored-by: Michael Puehringer <[email protected]> * bug: merge data subtype object * React 18 Migration * Fix typings * Fix client config typings * Pin ordino, tourdino * Add initial value to cohorts array * Cleanup * tsconfig * Update package.json --------- Co-authored-by: Holger Stitz <[email protected]> Co-authored-by: Champari Oltion <[email protected]> Co-authored-by: Michael Pühringer <[email protected]> Co-authored-by: Vanessa Stoiber <[email protected]> Co-authored-by: Klaus Eckelt <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: dvvanessastoiber <[email protected]> Co-authored-by: Michael Puehringer <[email protected]> Co-authored-by: oltionchampari <[email protected]> Co-authored-by: Moritz Heckmann <[email protected]>

Autoselect rootcohort if onboarding was done #579

66faf88

keckelt requested a review from PatrickAdelberger October 6, 2022 09:51

keckelt self-assigned this Oct 6, 2022

keckelt added priority: low release: patch PR merge results in a new patch version type: feature New feature or request labels Oct 6, 2022

keckelt marked this pull request as ready for review October 6, 2022 09:55

format code

5f84ce9

PatrickAdelberger approved these changes Oct 13, 2022

View reviewed changes

keckelt merged commit d28ee99 into develop Oct 13, 2022

keckelt deleted the 579_auto_select_root branch October 13, 2022 07:00

dvvanessastoiber mentioned this pull request Feb 9, 2023

Release 4.1.0 #54

Merged

2 tasks

thinkh mentioned this pull request Aug 14, 2023

Release 5.0.0 #63

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Automatically select root cohort if onboarding was already done#48

Automatically select root cohort if onboarding was already done#48
keckelt merged 2 commits intodevelopfrom
579_auto_select_root

keckelt commented Oct 6, 2022 •

edited

Loading

Uh oh!

PatrickAdelberger left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

keckelt commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Developer Checklist (Definition of Done)

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Uh oh!

PatrickAdelberger left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

keckelt commented Oct 6, 2022 •

edited

Loading