Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(wren-ai-service): improve misleading pipeline prompt #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

chore(wren-ai-service): improve misleading pipeline prompt #1818

merged 1 commit into from
Jul 3, 2025

Conversation

@cyyeh
Copy link
Member

@cyyeh cyyeh commented Jul 3, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Improved clarity in language selection by ensuring responses are generated in the language specified in the input section.
    • Adjusted response length limits: 150 words for Traditional/Simplified Chinese, Korean, or Japanese; 110 words for other languages.

@cyyeh cyyeh requested a review from yichieh-lu July 3, 2025 05:56
@cyyeh cyyeh added module/ai-service ai-service related ci/ai-service ai-service related labels Jul 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 3, 2025 •
edited
Loading

Walkthrough

The system prompt in the misleading_assistance pipeline was updated to reference the language specified in the "Language" section of the input, clarifying that the response must be in that language. The word limit condition was also refined: 150 words for certain East Asian languages, and 110 words for others.

Changes

File(s) Change Summary
wren-ai-service/src/pipelines/generation/misleading_assistance.py Refined prompt to reference input "Language" section for response language; clarified word limit rules.

Possibly related PRs

Suggested labels

wren-ai-service

Poem

A prompt now knows which tongue to use,
From "Language" it must choose.
For Chinese, Korean, or Japanese,
150 words—if you please!
For all the rest, keep it tight,
110 words—just right.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Pylint (3.3.7)
wren-ai-service/src/pipelines/generation/misleading_assistance.py
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c46cd2 and 7d2c4fa.

📒 Files selected for processing (1)
  • wren-ai-service/src/pipelines/generation/misleading_assistance.py (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
wren-ai-service/src/pipelines/generation/misleading_assistance.py (1) 
Learnt from: andreashimin
PR: Canner/WrenAI#1414
File: wren-ui/src/apollo/server/utils/error.ts:0-0
Timestamp: 2025-03-18T10:28:10.593Z
Learning: The typo in error code enum names ("IDENTIED_AS_GENERAL" and "IDENTIED_AS_MISLEADING_QUERY" instead of "IDENTIFIED_AS_GENERAL" and "IDENTIFIED_AS_MISLEADING_QUERY") in wren-ui/src/apollo/server/utils/error.ts was recognized but intentionally not fixed as it was considered out of scope for PR #1414.
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: pytest
  • GitHub Check: pytest
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
wren-ai-service/src/pipelines/generation/misleading_assistance.py (2)

26-26: LGTM - Clear language specification.

The clarification to reference the "Language section of the ### INPUT ### section" is precise and aligns well with the template structure where Language: {{language}} appears on line 44.

28-28: LGTM - Appropriate word limit logic for different languages.

The conditional word limit makes sense - East Asian languages (Traditional/Simplified Chinese, Korean, Japanese) often require more words to express the same concepts due to their character-based nature. The 150/110 word split is reasonable.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in a Comment
  • Commit Unit Tests in branch chore/ai-service/improve-text2sql

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cyyeh cyyeh merged commit 4e5d866 into main Jul 3, 2025
15 checks passed
@cyyeh cyyeh deleted the chore/ai-service/improve-text2sql branch July 3, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yichieh-lu yichieh-lu yichieh-lu approved these changes

Assignees

No one assigned

Labels

ci/ai-service ai-service related module/ai-service ai-service related wren-ai-service

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyyeh @yichieh-lu