Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(wren-ai-service): revert add quotes #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2025
Merged

chore(wren-ai-service): revert add quotes #1925

merged 3 commits into from
Sep 1, 2025

Conversation

@cyyeh
Copy link
Member

@cyyeh cyyeh commented Sep 1, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Migrated SQL identifier quoting to a new engine for more consistent, robust behavior without changing the public API.
  • Bug Fixes
    • Improved accuracy of SQL identifier quoting, reducing failures on complex queries.
    • Clearer error messages when quoting fails.

@cyyeh cyyeh added module/ai-service ai-service related ci/ai-service ai-service related labels Sep 1, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 1, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced token-based SQL identifier quoting and squish logic with sqlglot-based transpilation in engine.add_quotes; removed related helpers. Updated imports and error handling accordingly. Deleted test file covering add_quotes, clean_generation_result, and remove_limit_statement.

Changes

Cohort / File(s) Summary
Engine: switch to sqlglot quoting
wren-ai-service/src/core/engine.py		 Removed sqlparse/token-based squish and quoting helpers; updated add_quotes to use sqlglot.transpile with identify=True; adjusted imports and exceptions; public signatures unchanged.
Tests: removal of engine tests
wren-ai-service/tests/pytest/test_engine.py		 Deleted tests for add_quotes, clean_generation_result, and remove_limit_statement, including related imports and classes.

Sequence Diagram(s)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • yichieh-lu

Poem

I nibble code like clover sprigs—
swap tokens for a glot that sings.
Quotes now bloom on fields of SQL,
tests hop off, their burrows fell.
Thump-thump, I ship with tidy cheer—
a sleeker path is crystal-clear. 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 531eb7e and 1a2ab13.

📒 Files selected for processing (2)
  • wren-ai-service/src/core/engine.py (2 hunks)
  • wren-ai-service/tests/pytest/test_engine.py (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/ai-service/revert-add-quotes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cyyeh cyyeh merged commit f623d71 into main Sep 1, 2025
10 of 11 checks passed
@cyyeh cyyeh deleted the chore/ai-service/revert-add-quotes branch September 1, 2025 06:49
cyyeh added a commit that referenced this pull request Sep 2, 2025
@cyyeh
chore(wren-ai-service): revert add quotes (#1925)
6484038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yichieh-lu yichieh-lu yichieh-lu approved these changes

Assignees

No one assigned

Labels

ci/ai-service ai-service related module/ai-service ai-service related wren-ai-service

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyyeh @yichieh-lu