Properties on axis renderers to Objc (Fixes #4800) #4801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the three public properties on XAxisRenderer and YAxisRenderer, available for access from Objc.
pmairoldi
approved these changes
May 25, 2022
Collaborator
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the three public properties on XAxisRenderer and YAxisRenderer, available for access from Objc.
Issue Link #4800
Goals ⚽
To make it possible to use these classes from Objc
Implementation Details 🚧
These classes and many of the functions in them are already accessible from Objc. I think that the properties should also be (and indeed, they were until the move from
AxisRendererBasetoAxisRendererin #4456)