fix(query): fix fp for mssql_server_auditing_disabled#7492
fix(query): fix fp for mssql_server_auditing_disabled#7492cx-miguel-dasilva merged 5 commits intoCheckmarx:masterfrom cx-romeu-silva:AST-85090
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 4266028 | Triggered | Generic Password | bbafc6e | assets/queries/terraform/azure/mssql_server_auditing_disabled/test/negative2.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
cx-artur-ribeiro
left a comment
There was a problem hiding this comment.
Nice work Romeu!
Reason for Proposed Changes
server_idfield. This field must reference the correct SQL Server instance's ID, not the resource name.Proposed Changes
azurerm_mssql_server_extended_auditing_policyresource exists, verify itsserver_idpoints to a validazurerm_mssql_serverid.I submit this contribution under the Apache-2.0 license.