feat(query): new query "Beta - Databricks Workspace Without CMK" - Terraform/azure #7770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
KICS version: v2.1.17
|
…n_transit_is_encrypted_in_azure_databricks_using_CMK
…06783_3_1_8_ensure_data_at_rest_and_in_transit_is_encrypted_in_azure_databricks_using_CMK
…06783_3_1_8_ensure_data_at_rest_and_in_transit_is_encrypted_in_azure_databricks_using_CMK
…n_transit_is_encrypted_in_azure_databricks_using_CMK
…06783_3_1_8_ensure_data_at_rest_and_in_transit_is_encrypted_in_azure_databricks_using_CMK
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21271469 | Triggered | Generic Password | 47a98eb | assets/queries/terraform/azure/unrestricted_sql_server_access/test/negative4.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…06783_3_1_8_ensure_data_at_rest_and_in_transit_is_encrypted_in_azure_databricks_using_CMK
…n_transit_is_encrypted_in_azure_databricks_using_CMK
…encrypted_in_azure_databricks_using_CMK' of https://github.com/Checkmarx/kics into AST-106783_3_1_8_ensure_data_at_rest_and_in_transit_is_encrypted_in_azure_databricks_using_CMK
…n_transit_is_encrypted_in_azure_databricks_using_CMK
…n_transit_is_encrypted_in_azure_databricks_using_CMK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
Currently there is no query to ensure a "azurerm_databricks_workspace" resource has CMK encryption enabled for managed disks.
Quoting CIS_Microsoft_Azure_Foundations_Benchmark_v5.0.0 page 49: "
By default in Azure, data at rest tends to be encrypted using Microsoft-managed keys. If your organization wants to control and manage encryption keys for compliance and defense-in-depth, customer-managed keys can be established."For the relevant resource to enable CMK 2 fields must be validated:
Firstly the
customer_managed_key_enabledfield must be set totrue, with this field we determine "Is the workspace enabled for customer managed key encryption?" as stated in the documentation. It is mandatory for CMK.Secondly the
managed_disk_cmk_key_vault_key_idfield should be set.Proposed Changes
Implemented the missing query with a
cwevalue of 522, "MEDIUM" severity and the "Encryption" category; these were mainly based on the "Encryption On Managed Disk Disabled" query that checks that a managed disk has encryption enabled.The query will flag a given"azurerm_databricks_workspace" resource if:
trueReference
I submit this contribution under the Apache-2.0 license.