fix(query): passwords and secrets fp for run after triggers#7713
Merged
cx-ricardo-jesus merged 9 commits intomasterfrom Sep 24, 2025
Merged
Conversation
Contributor
cx-artur-ribeiro
requested changes
Sep 23, 2025
Contributor
cx-artur-ribeiro
left a comment
There was a problem hiding this comment.
Despite the description, all good to me.
…12469-FP-Passwords_and_Secrets_Generic_Token_ARM
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 20838717 | Triggered | Generic Password | 51230b8 | assets/queries/azureResourceManager/sql_server_database_with_alerts_disabled/test/negative8.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
or
Given the limitations of the passwords_and_secrets's queries it is impossible to distinguish these cases in scenarios that rely on different naming schemes that also finish with "token". An action like "HTTP2_-_Get_OAuth_Token" would also be flagged even after this fix because it is impossible to predict how a user will name an action.
Considering the first example it is also impossible to filter by value associated with the field like "Succeeded". Since the scan will be line by line it is likely that said value is not available; otherwise , knowing the 7 possible values, the filtering process could be applicable to many more samples and still safe enough to not cause new False Negatives.
Proposed Changes
Added a test "negative56.json" with all 4 fields to be ignored.
Finally, after fix(query): added two new allowRules on "Generic Secret" and "Generic Token" queries from Passwords and Secrets #7698 was merged some negative test naming isues were apparent, there were 2 negative54 tests (from previous PRs) and 2 negative56 tests, these did not cause issues because their file types were different but the naming was now corrected so that there are 58 tests in total finishing with negative58.bicep.
I submit this contribution under the Apache-2.0 license.