fix(analyzer): add unwanted channel drain before done channel returns for correct line count#7942
Merged
cx-artur-ribeiro merged 10 commits intomasterfrom Jan 29, 2026
Merged
Conversation
…he all excluded files to be taken into consideration
Contributor
cx-miguel-dasilva
previously approved these changes
Jan 12, 2026
Contributor
cx-rui-araujo
left a comment
There was a problem hiding this comment.
@cx-artur-ribeiro check my comment please
…n to use maps.keys
cx-miguel-dasilva
previously approved these changes
Jan 21, 2026
cx-bruno-silva
previously approved these changes
Jan 26, 2026
e60cbe3
cx-rui-araujo
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
wg.Wait()), the channels are closed and a done signal is sent. However, thecomputeValues()function uses a select statement that races between reading messages from unwanted and receiving the done signal.Proposed Changes
unwantedchannel before exiting;ListSupportedCloudProvidersto matchListSupportedPlatforms()implementation, reducing tech dept and automatically fetch supported cloud providers from the constants;I submit this contribution under the Apache-2.0 license.