Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update release workflow #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update release workflow #126

merged 1 commit into from
Aug 27, 2024

Conversation

@lone17
Copy link
Contributor

@lone17 lone17 commented Aug 27, 2024

Changes:

  • Change default bump to patch
  • Don't update the release if there is no bump

Note for the team @taprosoft:

  • Merging this PR to main will bump a patch version.
  • Since feat: merge develop #123 contains a big update, you might want to bump a minor version instead. To do this, simply add bump:minor to the PR message.

@lone17
Copy link
Contributor Author

lone17 commented Aug 27, 2024

@taprosoft
Side note: since you are developing on the develop branch before merging to main, you should do a rebase instead of merge. That way you will have the feature history in main and the workflow will create a nice changelog like this https://github.com/Cinnamon/kotaemon/releases/tag/v0.3.0

@taprosoft taprosoft merged commit 5946fd3 into Cinnamon:main Aug 27, 2024
@lone17 lone17 deleted the misc/update-release-workflow branch August 28, 2024 13:07
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
@lone17 @phv2312
change default bump to patch, don't create release if there is no bump (
2392e16 
Cinnamon#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@taprosoft taprosoft taprosoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lone17 @taprosoft