Addition of HSRP modules under ACI L3out#505
Merged
lhercot merged 10 commits intoCiscoDevNet:masterfrom Nov 17, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
===========================================
- Coverage 96.52% 35.31% -61.21%
===========================================
Files 183 210 +27
Lines 8479 9720 +1241
Branches 1265 1447 +182
===========================================
- Hits 8184 3433 -4751
- Misses 222 6287 +6065
+ Partials 73 0 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akinross
requested changes
Oct 24, 2023
… class queries in the HSRP modules
akinross
requested changes
Oct 26, 2023
tests/integration/targets/aci_hsrp_interface_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
akinross
requested changes
Nov 1, 2023
gmicol
requested changes
Nov 6, 2023
sajagana
reviewed
Nov 8, 2023
gmicol
requested changes
Nov 9, 2023
Collaborator
gmicol
left a comment
There was a problem hiding this comment.
Have you tried it on every APIC version we have at our disposals (especially the old 4.2 version where a lot of class objects/attributes do not exist) ?
lhercot
requested changes
Nov 17, 2023
Collaborator
|
is part of issue #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.