Add aci_system_connectivity_prefs module#601
Merged
lhercot merged 12 commits intoCiscoDevNet:masterfrom Apr 18, 2024
Merged
Conversation
A new module has been added to facilitate reading and mutating a fabric's management connectivity preference (inband/out-of-band)
akinross
requested changes
Apr 11, 2024
tests/integration/targets/aci_system_connectivity_prefs/tasks/main.yml
Outdated
Show resolved
Hide resolved
| description: | ||
| - Interface to use for external connection. | ||
| type: str | ||
| choices: [ inband, ooband ] |
Collaborator
There was a problem hiding this comment.
Should we add following aliases?
Suggested change
| choices: [ inband, ooband ] | |
| choices: [ inband, ooband ] | |
| aliases: [interface_pref, int_pref, external_connection] |
Contributor
Author
There was a problem hiding this comment.
Those seem like good sensible aliases. I have no additional ones too add.
Imports have also been optimized.
The aci_system_connectivity_prefs module and its interface_pref attribute have been refactored to use clearer naming.
akinross
requested changes
Apr 12, 2024
Collaborator
akinross
left a comment
There was a problem hiding this comment.
one more change in description of module then I will approve
shrsr
requested changes
Apr 12, 2024
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new module has been added to facilitate reading and mutating a fabric's management connectivity preference (inband/out-of-band)
APIC Connectivity Preferences is a fabric-wide system setting which can set to either in-band or out-of-band communication.
Tests have been added to verify this setting can be read and updated