This repository was archived by the owner on Nov 3, 2020. It is now read-only.
Add support for 'auto-update specs repo' #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…popover, and the main menu
Member
|
I don't like this -- it'll lead to people updating too frequently again |
| case Update(options: InstallOptions) | ||
| } | ||
|
|
||
| struct InstallOptions { |
Member
Author
|
OK, so, I think I agree with @segiddins - I'm going to merge this, and release it for b8, but I will turn #260 back into a release blocker for the next release. I know how to do that elegantly now 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started thinking about what the Specs Repo update stuff should look like. I missed the simplest option, and instead went for a more complex but more design-y answer in #260 - thanks for the comments @segiddins
I think there's probably still a space for something like #260 - but it's vastly reduced it's need now.
and