docs(specs): align uiux system guidance #20
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR documents the StormCom UI/UX design system principles and implementation plan within the feature specification. It establishes token-driven design standards, accessibility requirements, and a phased approach to implementing the design system.
Key changes:
- Added comprehensive design system guidance covering tokens, theming, layout, components, and accessibility
- Restructured UI/UX tasks with clearer acceptance criteria and added new tasks for layout shells, a11y testing, and token governance
- Extended data model with
ConsentEventfor tracking user consent changes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| specs/001-multi-tenant-ecommerce/spec.md | Added "Design System & UI/UX Principles" section detailing token system, theming approach, accessibility standards, and documentation requirements |
| specs/001-multi-tenant-ecommerce/tasks.md | Replaced T009 subtasks with more granular UI/UX tasks (T009a-T009h, T010-T012) with specific acceptance criteria |
| specs/001-multi-tenant-ecommerce/plan.md | Added "Design System Implementation Plan" with three phases covering foundations, primitives, and tenant theming |
| specs/001-multi-tenant-ecommerce/data-model.md | Added ConsentEvent model and ConsentType enum for consent auditing; updated Store model comments for branding fields |
| enum ConsentType { | ||
| MARKETING_OPT_IN | ||
| MARKETING_OPT_OUT | ||
| TRACKING_OPT_OUT | ||
| } |
There was a problem hiding this comment.
The ConsentEvent model lacks a corresponding reverse relation field on the Store model. Add 'consentEvents ConsentEvent[]' to the Store model to maintain referential integrity in the schema.
There was a problem hiding this comment.
To use Codex here, create a Codex account and connect to github.
There was a problem hiding this comment.
The ConsentEvent model lacks a corresponding reverse relation field on the Store model. Add 'consentEvents ConsentEvent[]' to the Store model to maintain referential integrity in the schema.
@codex resolve the issue
There was a problem hiding this comment.
Summary
- Documented the
consentEventsreverse relation on the Store model to mirror ConsentEvent references. specs/001-multi-tenant-ecommerce/data-model.mdL112-L129 - Added the
consentEventsassociation to the Customer model to complete the bidirectional linkage. specs/001-multi-tenant-ecommerce/data-model.mdL861-L869
Testing
⚠️ npm test(not run; docs-only change)
| customerId String? | ||
| customer Customer? @relation(fields: [customerId], references: [id], onDelete: SetNull) |
There was a problem hiding this comment.
The ConsentEvent model lacks a corresponding reverse relation field on the Customer model. Add 'consentEvents ConsentEvent[]' to the Customer model to complete the bidirectional relationship.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f700c36eb4832aa7bb29945ebc7853