N°7633 - Reloads the same user multiple times if it no longer exists #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
reviewed
Dec 17, 2024
good catch Co-authored-by: Thomas Casteleyn <[email protected]>
good catch (again) Co-authored-by: Thomas Casteleyn <[email protected]>
Co-authored-by: Thomas Casteleyn <[email protected]>
odain-cbd
commented
Dec 17, 2024
Hipska
approved these changes
Dec 17, 2024
rquetiez
requested changes
Dec 17, 2024
|
|
||
| public function testFindUser_internaluser() | ||
| { | ||
| $sLogin = 'admin'.uniqid(); |
There was a problem hiding this comment.
Pourquoi introduire un aléa ? "FooLogin" (sans passer par une variable intermédiaire) serait plus clair.
There was a problem hiding this comment.
to avoid a colision with any other existing user with login "FooLogin". could happen with failed tests that missed the cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom
Same user is searched further times to display an object history with many caselogs (up to 300 searches observed by a customer). The cache management does not deal properly caselogs with author set with contact name (instead of login).
Fallback when unfound user is done on caselog display side...
Fix
Remember that a previous search failed to find a user by its contact name (UserRights::FindUser).