Thanks to visit codestin.com
Credit goes to github.com

Skip to content

N°8575 - chore(auth-ldap): Prepare for php 8.3 deprecation #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

N°8575 - chore(auth-ldap): Prepare for php 8.3 deprecation #720

merged 1 commit into from
Aug 1, 2025

Conversation

@Hipska
Copy link
Contributor

@Hipska Hipska commented May 23, 2025

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? N/A
Type of change? Enhancement

Objective

According to the docs, the signature ldap_connect(?string $host = null, int $port = 389) is deprecated as of PHP 8.3.0.

Proposed solution

Introduce new uri module setting and provide migration to be able to use the preferred way of ldap_connect.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

@github-project-automation github-project-automation bot moved this to First review needed in Combodo PRs dashboard May 23, 2025
@jf-cbd jf-cbd moved this from First review needed to Pending technical review in Combodo PRs dashboard Jun 6, 2025
jf-cbd
jf-cbd requested changes Jun 13, 2025
View reviewed changes
Copy link
Member

@jf-cbd jf-cbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your PR ! Sounds all good, but I'm proposing a change on the way to "compute" the URI, so it's similar to what we did in another extension :)

@jf-cbd jf-cbd changed the title chore(auth-ldap): Prepare for php 8.3 deprecation N°8575 - chore(auth-ldap): Prepare for php 8.3 deprecation Jul 29, 2025
@jf-cbd jf-cbd merged commit 3da33c4 into Combodo:develop Aug 1, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Pending technical review to Finished in Combodo PRs dashboard Aug 1, 2025
@jf-cbd
Copy link
Member

jf-cbd commented Aug 1, 2025

Thanks for your contribution @Hipska !

@Hipska Hipska deleted the chore/ldap_connect_uri branch August 4, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jf-cbd jf-cbd jf-cbd requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hipska @jf-cbd