N°6759 factorize config #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdalsass
reviewed
Aug 21, 2025
|
|
||
| } | ||
|
|
||
| public function AddEditor(string $sPrevConfig, string $sNewConfig) { |
There was a problem hiding this comment.
Dont understand why there is 2 parameters, the only usage pass the same string (line 105)
bdalsass
reviewed
Aug 22, 2025
| $oAlert = GetAlertFromException($e); | ||
| $oP->AddUiBlock($oAlert); | ||
| } | ||
| $oLogCenterController = new ConfigEditorController(); |
There was a problem hiding this comment.
wrong var name oLogCenterController (copy past 🧐)
| @@ -0,0 +1,172 @@ | |||
| <?php | |||
|
|
|||
datamodels/2.x/itop-config/src/Controller/ConfigEditorController.php
Outdated
Show resolved
Hide resolved
datamodels/2.x/itop-config/src/Controller/ConfigEditorController.php
Outdated
Show resolved
Hide resolved
| 'sTransactionId' => utils::GetNewTransactionId(), | ||
| 'sChecksum' => $sConfigChecksum, | ||
| 'sPrevConfig' => $sCurrentConfig, | ||
| 'sNewConfig' => $sCurrentConfig, |
There was a problem hiding this comment.
2 identical parameters, really needed ?
datamodels/2.x/itop-config/src/Validator/iTopConfigValidator.php
Outdated
Show resolved
Hide resolved
| document.getElementById('ibo-main-content').addEventListener('click',repositionEditor); | ||
|
|
||
| document.getElementById('cancel_button').onclick = ()=>{ | ||
| $("#operation").attr('value', 'revert'); |
bdalsass
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.