Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor tile charts + fixes #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 27, 2025
Merged

Refactor tile charts + fixes #1438

merged 15 commits into from
Sep 27, 2025
+3,061 −1,079

Conversation

@peuter
Copy link
Member

@peuter peuter commented Sep 6, 2025

mainly fixes for problems found during refactoring.

Also reworks the already started distrobox dev-container to one with a working webserver for testing. Uses our own docker container base image to support all proxy/backend possible (I could only test openhab here). Also add documentation on how to use it.

@coveralls
Copy link

coveralls commented Sep 6, 2025 •
edited
Loading

Coverage Status

coverage: 55.866% (-0.2%) from 56.036%
when pulling 12ebc5f on peuter:refactor-tile-charts
into 4de5619 on CometVisu:develop.

@ChristianMayer
Copy link
Member

Loading the demo-tile it's failing with:

qx.core.AssertionError: The value 'natural' must have any of the values defined in the array 'linear,step,basis'
Normalized Stack: 
	qx.type.BaseError:43:24
	qx.Bootstrap:49:24
	qx.core.AssertionError:53:25
	qx.Bootstrap:49:24
	qx.core.Assert:80:21
	qx.core.Assert:387:45
	qx.core.Property:747:38 [repeated 3 times]
	qx.core.MProperty:60:36
	cv.ui.structure.tile.components.chart.Dataset:182:16
	cv.ui.structure.tile.components.chart.Dataset:41:12
	qx.Class:1453:41
	cv.ui.structure.tile.components.Chart:454:27
	```

@ChristianMayer
Copy link
Member

And in the console log I see:

Native.js:67 004854 qx.Promise: Unhandled promise rejection: Error: The value 'natural' must have any of the values defined in the array 'linear,step,basis'
    at wrapper._init (Dataset.js:170:14)
    at wrapper.construct (Dataset.js:16:10)
    at wrapper._init (Chart.js:454:25)

@ChristianMayer
Copy link
Member

There is also:

Native.js:67 004785 : Assertion error! Invalid incoming value for property 'curve' of class 'cv.ui.structure.tile.components.chart.Dataset': The value 'natural' must have any of the values defined in the array 'linear,step,basis'
 Stack trace: 
qx.core.AssertionError:54:49,qx.Bootstrap:49:24,qx.core.Assert:80:21,qx.core.Assert:387:45,qx.core.Property:747:38,qx.core.Property:747:38,qx.core.Property:747:38,qx.core.Property:585:28,qx.core.MProperty:60:36,cv.ui.structure.tile.components.chart.Dataset:182:16,cv.ui.structure.tile.components.chart.Dataset:41:12,qx.Class:1453:41,cv.ui.structure.tile.components.Chart:454:27
process	@	Native.js:67
set	@	VM42850:3
eval	@	VM42850:3
eval	@	VM42849:3
eval	@	VM42231:3
_init	@	Dataset.js:170
construct	@	Dataset.js:16
_init	@	Chart.js:454
await in _init		
_applyConnected	@	AbstractCustomElement.js:65
set	@	VM42631:3
eval	@	VM42631:6
eval	@	VM42630:3
connectedCallback	@	Controller.js:658
TemplatedElement	@	Controller.js:840
(anonymous)	@	Controller.js:600
(anonymous)	@	Controller.js:250
XMLHttpRequest.send		
parseSettings	@	Controller.js:314
parse	@	TemplateEngine.js:364
await in parse		
bootstrap	@	Application.js:884
_checkQueue	@	ConfigLoader.js:235
(anonymous)	@	ConfigLoader.js:169
XMLHttpRequest.send		
(anonymous)	@	ConfigLoader.js:183
XMLHttpRequest.send		
load	@	ConfigLoader.js:191
(anonymous)	@	Application.js:792
__init__P_2_3	@	Application.js:774
main	@	Application.js:400
done	@	index.js:12305
signalStartup	@	index.js:12328
(anonymous)	@	index.js:12355
setTimeout		
(anonymous)	@	index.js:12351
checkForEnd	@	index.js:12564
onLoad	@	index.js:12572
elem.onreadystatechange.elem.onload	@	index.js:12442
script		
loadScript	@	index.js:12435
flushScriptQueue	@	index.js:12577
begin	@	index.js:12349
init	@	index.js:12363
(anonymous)	@	index.js:12752```

@ChristianMayer
Copy link
Member

ChristianMayer commented Sep 14, 2025 •
edited
Loading

Ah, one moment, I didn't update my npm yet - I'll try again

Edit: False alarm. After running

source venv/bin/activate
npm ci

and then again npx qx compile --watch --clean the behavior stayed identical with the same error messages

@ChristianMayer
Copy link
Member

Sometimes after reload I get:

Uncaught (in promise) Error: loadParts "Structure" failed
    at wrapper.parse (TemplateEngine.js:359:15)
    at async wrapper.bootstrap (Application.js:884:9)

parse	@	TemplateEngine.js:359
await in parse		
bootstrap	@	Application.js:884
_checkQueue	@	ConfigLoader.js:235
(anonymous)	@	ConfigLoader.js:169
XMLHttpRequest.send		
(anonymous)	@	ConfigLoader.js:183
XMLHttpRequest.send		
load	@	ConfigLoader.js:191
(anonymous)	@	Application.js:792
__init__P_2_3	@	Application.js:774
main	@	Application.js:400
done	@	index.js:12308
signalStartup	@	index.js:12331
(anonymous)	@	index.js:12358
setTimeout		
(anonymous)	@	index.js:12354
checkForEnd	@	index.js:12567
onLoad	@	index.js:12575
elem.onreadystatechange.elem.onload	@	index.js:12445
script		
loadScript	@	index.js:12438
flushScriptQueue	@	index.js:12580
begin	@	index.js:12352
init	@	index.js:12366
(anonymous)	@	index.js:12755

@peuter
Copy link
Member Author

peuter commented Sep 21, 2025

I fixed the natural curve value warning and another error in the demo barchart. I can't reproduce the structure loading problem. Doesn't really seem to be related to this PR anyways.

@ChristianMayer ChristianMayer merged commit 0677743 into CometVisu:develop Sep 27, 2025
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianMayer ChristianMayer ChristianMayer approved these changes

Assignees

No one assigned

Labels

bug / bugfix enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peuter @coveralls @ChristianMayer