Issue 67 root move comments #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes issue #67: Add ability to include comments before the first move - Modified writeMoves function to handle root move comments when isRoot=true - Updated String() method to handle root move comments even when no children exist - Added comprehensive tests for root move comments including: - Basic root move comments - Comments on empty games - Multiple comments - Comments with tag pairs - Comments with variations The fix ensures that comments added to the root move (before any moves are made) are properly included in the generated PGN output.
- Updated the String() method to ensure root move comments are included even when there are no child moves. - Added multiple test cases for root move comments, covering scenarios such as comments on empty games, multiple comments, comments with tags, and comments with variations. - Improved the structure of PGN output to maintain the correct order of tags, comments, and moves. These changes ensure that comments added to the root move are accurately reflected in the generated PGN output.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 67.92% 68.00% +0.08%
==========================================
Files 27 27
Lines 4866 4873 +7
==========================================
+ Hits 3305 3314 +9
+ Misses 1433 1431 -2
Partials 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.