Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(Case Converter) Add lowercase and uppercase #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CorentinTh merged 12 commits into from
Aug 9, 2023
Merged

(Case Converter) Add lowercase and uppercase #534

CorentinTh merged 12 commits into from
Aug 9, 2023

Conversation

@marvin-j97
Copy link
Contributor

@marvin-j97 marvin-j97 commented Jul 13, 2023

Closes #532

@vercel
Copy link

vercel bot commented Jul 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Aug 9, 2023 9:34pm

CorentinTh
CorentinTh reviewed Jul 19, 2023
View reviewed changes
Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using strippedInput ? for the upper and lowercase it may be relevant to just use input ?

@marvin-j97
Copy link
Contributor Author

marvin-j97 commented Jul 19, 2023

Why using strippedInput ? for the upper and lowercase it may be relevant to just use input ?

I used it so it lines up with how the other formats are converted. If it's not stripped, lower -and uppercase are the only that keep numbers and special characters and it looks really wrong.

It's really a question if anything but letters should be allowed at all.

CorentinTh and others added 6 commits August 9, 2023 23:29
@CorentinTh CorentinTh enabled auto-merge (squash) August 9, 2023 21:34
@CorentinTh CorentinTh disabled auto-merge August 9, 2023 21:34
@CorentinTh CorentinTh enabled auto-merge (squash) August 9, 2023 21:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CorentinTh
Copy link
Owner

CorentinTh commented Aug 9, 2023

Hi @marvin-j97 !
Thanks you for the changes, I made some minor changes to your PR (and rebased it on main, but it made a mess since I can't push force pr from forks 😅 )

Thanks again and sorry for the delay, I'm kinda really busy at the moment 🙏🏻

@CorentinTh CorentinTh disabled auto-merge August 9, 2023 21:45
@CorentinTh CorentinTh merged commit 7b6232a into CorentinTh:main Aug 9, 2023
@marvin-j97 marvin-j97 deleted the case-converter/more-cases branch August 9, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CorentinTh CorentinTh CorentinTh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add lowercase and UPPERCASE to Case converter tool

2 participants

@marvin-j97 @CorentinTh