build: Optimize release build for size #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istudyatuni
reviewed
May 8, 2025
Contributor
Author
|
12.34 M = 12M34
It is a way to make the position of the dot more visible.
fre. 9. maj 2025 11.12 skrev Ilia ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In Cargo.toml
<#128 (comment)>:
> @@ -38,3 +38,11 @@ tracing-log = "0.2.0"
tracing-subscriber = "0.3.19"
tui-textarea = "0.7.0"
tui_confirm_dialog = "0.3.1"
+
+# Release build optimize size.
+# Run strip manually after build to reduce further.
+[profile.release]
+lto = true
+opt-level = 'z' # Optimize for size.
What does mean number after M?
—
Reply to this email directly, view it on GitHub
<#128 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB7VYLAIRCZFRCZ4NGBY325RWQXAVCNFSM6AAAAAB4WF6U7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRXGYZTEOBVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
istudyatuni
reviewed
May 9, 2025
Contributor
Author
|
Why would you remove comments that explain?
Both 's' and 'z' optimize for size.
They are explained here:
https://doc.rust-lang.org/cargo/reference/profiles.html#opt-level
…On Fri, 9 May 2025 at 16:18, Ilia ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Cargo.toml
<#128 (comment)>:
> @@ -38,3 +38,11 @@ tracing-log = "0.2.0"
tracing-subscriber = "0.3.19"
tui-textarea = "0.7.0"
tui_confirm_dialog = "0.3.1"
+
+# Release build optimize size.
As I understand all these comments can be removed now
—
Reply to this email directly, view it on GitHub
<#128 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB7VYOZXCEFAXSI3TZYMD25S2JRAVCNFSM6AAAAAB4WF6U7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRYGUZTCNJZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
Do I need to do something for this to move on? |
istudyatuni
approved these changes
May 29, 2025
Collaborator
istudyatuni
left a comment
There was a problem hiding this comment.
No, thanks! Sorry for the delays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system this will reduce the release build binary to about half size.