fix(bookmarks): Fix crash due to non-total ordering in the sorting lamba #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52a28f0 to
2094b3f
Compare
istudyatuni
reviewed
Jun 16, 2025
Given two Parsed and one Unparsable line, the current lambda would return Ordering::Equal for both Parsed/Unparsable pairings, but then possibly declare that the Parsed/Parsed values differ (unless their timestamps are equal). This is contradictory and violates the requirements of the sorted_by() method, causing it to eventually panic.
2094b3f to
ba5b741
Compare
istudyatuni
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given two Parsed and one Unparsable line, the current lambda would return Ordering::Equal for both Parsed/Unparsable pairings, but then possibly declare that the Parsed/Parsed values differ (unless their timestamps are equal). This is contradictory and violates the requirements of the sorted_by() method, causing it to eventually panic.