convert tabs to spaces #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using tabs in the ui breaks the ratatui diff and leads to rendering artifacts. This converts tabs to spaces with a fixed tab-width of 4. Ideally, the tab-width should be configurable, but until then 4 might be a reasonable compromise. (I'm assuming that few people who indent with tabs are using a larger tab-width.)
Cretezy
approved these changes
Oct 6, 2024
Cretezy
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using tabs in the ui breaks the ratatui diff and leads to rendering artifacts. This converts tabs to spaces with a fixed tab-width of 4. Ideally, the tab-width should be configurable, but until then 4 might be a reasonable compromise.
(I'm assuming that few people who indent with tabs are using a larger tab-width.)
fixes #49