NumPy arrays compatibility #759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This kind of testing is often much harder that it looks, does this method work if the individual is a class inheriting numpy arrays? |
|
It does not because im checking the module name of each array. Although, I have created a new version with a simpler method that seems to work fine, should I create a new pull request? (Sorry I'm new to open source) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the ind2 array was not updated when working with NumPy arrays.
A check is added to verify if ind1 and ind2 are NumPy arrays.
If they are, the slices being swapped are copied using .copy() .
If they are not, the swap operation proceeds as before.