Fix for workflow groups are not deleted during the deletion of the associated collection #8063. #11351
Conversation
…sociated collection.
There was a problem hiding this comment.
@im-shivamb : Thanks for the PR. Unfortunately, though, I'm not able to reproduce the bug that this is supposed to fix. On a DSpace 7.6.x site, I've tried the following:
- Create a new Collection
- Add two Role groups to that Collection (I used ADMIN and SUBMIT). Add a few EPersons to each group.
- Note down the names of both groups. Verify they can be found through the "Access Control" -> "Groups" admin menu
- Now, Delete the Collection.
- Go back to "Access Control" -> "Groups" and search for the two groups. They are both gone.
Basically, I'm not sure this bug exists anymore. Or maybe I don't understand how to test it. If you can provide more details on how to reproduce this bug, I can try again.
Finally, assuming this bug is reproducible, I think your PR needs to have automated tests added that will prove that the groups are cleaned up after deletion. These might be added to the existing CollectionTest class. I have another minor comment inline below.
| String roleId = collectionRole.getRoleId(); | ||
| int stepId = -1; | ||
| switch (roleId) { | ||
| case "reviewer": |
There was a problem hiding this comment.
Please don't hardcode the values here. Instead, you should be using CollectionRoleService.LEGACY_WORKFLOW_STEP1_NAME.
Same with the other hardcoded values below, there's variables that can replace each if you use CollectionRoleService directly
References
Description
Remove workflow groups associated with a collection when the collection is deleted.
Instructions for Reviewers
• Delete a collection that has one or more workflow groups assigned.
• Verify that the associated workflow groups are also removed from the database.
• Confirm that no other collections or unrelated workflow groups are affected.
• Check for proper handling in both UI and backend.
List of changes in this PR:
• Updated CollectionServiceImpl.java to remove workflow groups linked to a collection when the collection is deleted.
How to Test