Major changes #57
Merged
Major changes #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for markdown line breaks
these files are automatically picked up by the following vscode extension https://github.com/LuaLS/lua-language-server and used for intellisense, helps a lot and also encourages good practices in some cases
API BREAKING CHANGE HERE: - FREAD becomes O_RDONLY - FWRITE becomes O_WRONLY - FCREATE gets removed (to get same effect use O_CREAT | O_WRONLY) - exposes O_CREAT - exposes O_TRUNC - FRDWR becomes O_RDWR Seek modes remain the same name for simplicity
and add warnings if loading images or fonts and discarding their return values now all TTF alignment tokens are forwarded to LUA
This was referenced Oct 30, 2025
|
PS2SDK broke enceladus. PR paused for now |
42d0f3e to
67a4f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking changes:
file open modes
FREADbecomesO_RDONLYFWRITEbecomesO_WRONLYFCREATEgets removed (to get same effect useO_CREAT | O_WRONLY)O_CREATO_TRUNCFRDWRbecomesO_RDWRDeprecation of
System.rename()Instead, use
System.moveFile()Both functions were internally the same, so I removed rename since it's name does not match what happens inside
important changes
New return values for several functions that did not have one or had an incomplete one:
System.removeFile(): returns the result of C remove()System.createDirectory(): returns the result of Cmkdir()System.removeDirectory(): returns the result of Crmdir()System.closeFile(): returns the result of Cclose()System.seekFile(): returns the result ofseek()(Wich is the new seek position of this file)System.readFile(): now returns both the readed data and the length of the readed data (wich may be less than what you passed as parameter!)Also, some functions like the texture loading, will now return
nilon error. Wich allows better error handling, and makes intellisense raise warnings if you didn't check if a loaded image is nil before using