Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update puppet-lint.yml #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dargon789 merged 1 commit into from
Jun 12, 2025
Merged

Update puppet-lint.yml #595

Dargon789 merged 1 commit into from
Jun 12, 2025

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jun 12, 2025 •
edited by sourcery-ai bot
Loading

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Summary by Sourcery

Streamline the puppet-lint GitHub Actions workflow by modernizing triggers, runner, permissions, and removing manual Ruby setup steps

Enhancements:

  • Use array shorthand for push and pull_request branches
  • Add a weekly cron schedule for lint scans
  • Switch the runner to ubuntu-latest and name the job
  • Centralize and restrict workflow and job permissions

Chores:

  • Remove manual Ruby installation, dependency setup, and puppet-lint invocation steps

@Dargon789
Update puppet-lint.yml
6377caf 
Signed-off-by: AU_gdev_19 <[email protected]>
@codesandbox
Copy link

codesandbox bot commented Jun 12, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel
Copy link

vercel bot commented Jun 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat-project-uz7z ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 5:25pm

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 12, 2025 •
edited
Loading

Reviewer's Guide

This PR streamlines the puppet-lint GitHub Actions workflow by simplifying trigger syntax and schedule, introducing scoped permissions, updating the runner configuration, and removing the manual Ruby setup and puppet-lint installation steps.

File-Level Changes

Change Details Files
Simplify workflow triggers and add schedule
  • Refactor branch filters to inline YAML array
  • Add a weekly cron schedule for automatic runs
 .github/workflows/puppet-lint.yml
Introduce scoped permissions
  • Add top-level contents: read permission
  • Add job-level permissions for contents, security-events, and actions
 .github/workflows/puppet-lint.yml
Update runner configuration and job metadata
  • Rename the job to “Run puppet-lint scanning”
  • Switch runs-on from ubuntu-24.04-x64 to ubuntu-latest
 .github/workflows/puppet-lint.yml
Remove manual Ruby setup and puppet-lint steps
  • Delete rbenv and ruby-build installation commands
  • Remove bundler install and gem install puppet-lint steps
  • Omit explicit puppet-lint execution commands
  • Eliminate redundant Checkout and setup steps
 .github/workflows/puppet-lint.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Jun 12, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

sourcery-ai[bot]
sourcery-ai bot approved these changes Jun 12, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dargon789 - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit d909dff into main Jun 12, 2025
16 of 17 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-4 branch June 12, 2025 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

No one assigned

Labels

status:ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dargon789