Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@uurien
Copy link
Collaborator

@uurien uurien commented Oct 16, 2025

What does this PR do?

In esbuild plugin, when the dependecy @openfeature/core is not available, this is added to externals to prevent crashing build process when dependency is missing.

Motivation

Prevent crashing build process when @openfeature/core is missing.

@uurien uurien force-pushed the ugaitz/fixing-esbuild-openfeature branch from d4f4889 to e573925 Compare October 16, 2025 17:58
@github-actions
Copy link

Overall package size

Self size: 12.74 MB
Deduped: 115.35 MB
No deduping: 117.56 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.205.0 | 201.51 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.10 | 95.11 kB | 401.46 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@uurien uurien changed the title Fix esbuild requirement for @openfeature/core fix: esbuild requirement for @openfeature/core Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.11%. Comparing base (c2d2d84) to head (e573925).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6679   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files         503      503           
  Lines       21006    21006           
=======================================
  Hits        17670    17670           
  Misses       3336     3336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2025

Benchmarks

Benchmark execution time: 2025-10-16 18:06:07

Comparing candidate commit e573925 in PR branch ugaitz/fixing-esbuild-openfeature with baseline commit c2d2d84 in branch master.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 1593 metrics, 70 unstable metrics.

scenario:appsec-iast-no-vulnerability-control-24

  • 🟥 execution_time [+29.169ms; +36.893ms] or [+5.414%; +6.848%]

scenario:appsec-iast-startup-time-control-24

  • 🟥 execution_time [+47.951ms; +55.670ms] or [+6.492%; +7.538%]

scenario:appsec-iast-with-vulnerability-control-24

  • 🟥 execution_time [+68.259ms; +84.087ms] or [+7.746%; +9.542%]

scenario:net-control-24

  • 🟥 execution_time [+20.912ms; +22.457ms] or [+12.191%; +13.091%]
  • 🟥 instructions [+16.5M instructions; +18.0M instructions] or [+7.844%; +8.566%]

scenario:net-with-tracer-24

  • 🟥 execution_time [+28.620ms; +32.428ms] or [+6.392%; +7.243%]

scenario:plugin-dns-control-18

  • 🟥 execution_time [+91.873ms; +253.461ms] or [+5.261%; +14.515%]

@uurien uurien marked this pull request as ready for review October 17, 2025 03:35
@uurien uurien requested a review from a team as a code owner October 17, 2025 03:35
@uurien uurien merged commit 8900c5c into master Oct 17, 2025
771 of 793 checks passed
@uurien uurien deleted the ugaitz/fixing-esbuild-openfeature branch October 17, 2025 15:05
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants