Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DavidBuchanan314
Copy link
Owner

No description provided.

@DavidBuchanan314
Copy link
Owner Author

will also implement deleteSession, refreshSession (refreshSession should revoke the old session token, right?)

@DavidBuchanan314
Copy link
Owner Author

DavidBuchanan314 commented Jan 2, 2025

New plan:

  • give session tokens the same JTI as their corresponding refresh tokens.
  • deleteSession will cover both the session and refresh tokens (because they share the same jti)
  • refreshSession revokes the old session+refresh tokens and issues new ones.

general question: what's the point of having session tokens and refresh tokens being separate things?

@DavidBuchanan314
Copy link
Owner Author

DavidBuchanan314 commented Jan 2, 2025

Actually, refreshsession should probably not revoke access tokens (just the old refresh token). access tokens don't really need jti at all.

Edit: having jti in access tokens is useful for implementing deleteSession

@DavidBuchanan314 DavidBuchanan314 changed the title reject revoked auth tokens refreshSession, deleteSession Jan 2, 2025
@DavidBuchanan314 DavidBuchanan314 marked this pull request as ready for review January 2, 2025 21:37
@DavidBuchanan314 DavidBuchanan314 merged commit 0b061d0 into main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants