Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

#257 - added UpgradeEngineBuilder.MigrationLogicalName property, and …#261

Open
bcwiniger wants to merge 1 commit intoDbUp:mainfrom
bcwiniger:master
Open

#257 - added UpgradeEngineBuilder.MigrationLogicalName property, and …#261
bcwiniger wants to merge 1 commit intoDbUp:mainfrom
bcwiniger:master

Conversation

@bcwiniger
Copy link

…StandardExtensions.SetMigrationLogicalName extension to set the property

…and StandardExtensions.SetMigrationLogicalName extension to set the property
@bcwiniger
Copy link
Author

Can someone explain how to contribute to this project if the public API diff test fails? I am new to this and would like to know what I am doing wrong.

@dazinator
Copy link
Contributor

The public API test is an approval test - it compares the generated file describing the current API against the previous one which is the "golden master" definition. The test is there so you can more easily review if there are any breaking changes introduced. If there are breaking changes then it means we should bump the major version number for the release. I haven't reviewed this PR but if you havent introduced any breaking api changes then there is nothing to worry about. To get the test to pass, copy the contents of the generated file in place of the contents of the current "golden master" file so that the next time the test runs it will compare the API surface to itself = pass.

@bcwiniger
Copy link
Author

Thanks for the explanation. Since there are no breaking changes, just an addition, should I fix the test and resubmit?

@dazinator
Copy link
Contributor

@bcwiniger - yep!

@droyad
Copy link
Member

droyad commented Feb 26, 2018

@bcwiniger Appologies for us taking so long to look at this. What is the use case for this property?

@droyad
Copy link
Member

droyad commented Feb 26, 2018

I think this is related to #257

@droyad droyad added enhancement New feature or request dbup-core Issue or pull request regarding dbup-core project labels Feb 26, 2018
@sungam3r
Copy link
Member

sungam3r commented Aug 21, 2023

@bcwiniger Please rebase onto master if you are still interested.

@sungam3r sungam3r added the needs confirmation An issue or pull request await confirmation from their author label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbup-core Issue or pull request regarding dbup-core project enhancement New feature or request needs confirmation An issue or pull request await confirmation from their author

Projects

Status: Pull Requests to check

Development

Successfully merging this pull request may close these issues.

4 participants