Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix wrong variable name in GetAutoModRuleByIdAction #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2023
Merged

Fix wrong variable name in GetAutoModRuleByIdAction #1127

merged 1 commit into from
Apr 8, 2023

Conversation

@indyteo
Copy link
Contributor

@indyteo indyteo commented Apr 1, 2023

Description:
This PR fixes tiny error about the name of a field in GetAutoModRuleByIdAction.
The field has been renamed from stickerId to autoModRuleId.

Justification:
I suspect this typo comes from a copy-paste from the GetStickerByIdAction file and the author forgot to change it. The name I put comes from it's usage here:

public static GetAutoModRuleByIdAction getAutoModRuleById(long guildId, long autoModRuleId) {
    return new GetAutoModRuleByIdAction(guildId, autoModRuleId);
}

@Doc94
Copy link
Member

Doc94 commented Apr 2, 2023

Ups, xd
yeah when make this i use a base for know what need and in all cases i forget rename this things...
LGTM

@quanticc quanticc added the bug A general bug label Apr 8, 2023
@quanticc quanticc added this to the 3.2.5 milestone Apr 8, 2023
quanticc
quanticc approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@quanticc quanticc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quanticc quanticc merged commit 3f968b8 into Discord4J:3.2.x Apr 8, 2023
quanticc added a commit that referenced this pull request Apr 17, 2023
@quanticc
Merge #1127 into 3.3.0
c36fc96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quanticc quanticc quanticc approved these changes

@Doc94 Doc94 Doc94 approved these changes

Assignees

No one assigned

Labels

bug A general bug

Projects

None yet

Milestone

3.2.5

Development

Successfully merging this pull request may close these issues.

3 participants

@indyteo @Doc94 @quanticc