Fix unsigned long printing in requests (#1119) #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azn9
added a commit
to Azn9/Discord4J
that referenced
this pull request
Apr 2, 2024
* fix(long): fix unsigned long printing in requests (Discord4J#1119) * fix: revert format change --------- Co-authored-by: Axel Joly <[email protected]>
Azn9
added a commit
to Azn9/Discord4J
that referenced
this pull request
Apr 2, 2024
Azn9
added a commit
to Azn9/Discord4J
that referenced
this pull request
Jun 17, 2024
* fix(long): fix unsigned long printing in requests (Discord4J#1119) * fix: revert format change --------- Co-authored-by: Axel Joly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Handles long string conversion by overriding for some objects how they are converted to a String. I chose to create an utility function that use the instanceof operator to "override" manually how objects are converted to String.
Then, if the object provided is a Long, we use the
Long.printUnsignedLong(long)method to convert it to a String.Justification: Fixes #1119