feat: abstract Reaction Events #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc94
commented
May 7, 2025
| /** | ||
| * Represents an event related to a {@link discord4j.core.object.reaction.Reaction} with a user and more data of the reaction. | ||
| */ | ||
| public abstract class ReactionUserEmojiEvent extends ReactionBaseEmojiEvent { |
Member
Author
There was a problem hiding this comment.
not a fan for this name...
any suggestion?
Contributor
There was a problem hiding this comment.
UserTriggeredEmojiReactionEvent extends AbstractEmojiReactionEvent
Member
Author
There was a problem hiding this comment.
Feels strange not start with Reaction
And i wanna avoid the Abstract word based in how the MessageEvent dont use that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add abstract methods for the Reaction Events for allow more generic in the use of them
Justification: Close #1306