Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for using fully qualified names in alerts, deprecate using simple names in alerts #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: v1.30.2
wants to merge 4 commits into from
Closed

Add support for using fully qualified names in alerts, deprecate using simple names in alerts #1799

wants to merge 4 commits into from

Conversation

@Vankka
Copy link
Member

@Vankka Vankka commented Apr 16, 2025 •
edited
Loading

There is no way to listen for events without knowing the entire class name.
The current hack to get around this is to register a listener to every event, but this comes with various problems such as:

  • Performance problems (some events trigger very frequently)
    • Being unable to unregister from unused events reliably, due to some events sharing their HandlerList (see below attempted fix and resulting lag problems)
  • Having to replace the allLists field value to detect new events being added to it

Fixes GH-1793 (In cases where no simple names are used)
Fixes GH-1814

Docs PR: DiscordSRV/Documentation#85

@Vankka Vankka requested a review from granny April 16, 2025 20:01
@Vankka Vankka mentioned this pull request Jun 10, 2025
Merged
1 task
@Vankka Vankka requested a review from Scarsz June 14, 2025 19:55
@ANutley
Copy link
Member

ANutley commented Jun 15, 2025

DiscordSRV/src/main/resources/alerts/en.yml

Line 50 in e6dbac6

# - Trigger: <event name or /command>

Would it be worth changing this to something along the lines of "event fully qualified class name", however we may want something simpler that the average server owner would understand?

@Vankka Vankka linked an issue Jun 15, 2025 that may be closed by this pull request
Alerts don't work on Paper 1.21.5+ #1814
Closed
2 tasks
@Vankka Vankka force-pushed the feat/alerts-fully-qualified-class-names branch from e6dbac6 to 81d8360 Compare June 15, 2025 21:02
@OakLoaf
Copy link

OakLoaf commented Jul 23, 2025 •
edited
Loading

Is this safe to compile and use in production? Or is there anything currently holding it back?

Vankka added a commit that referenced this pull request Jul 23, 2025
@Vankka
Add support for using fully qualified names in alerts, deprecate usin…
21b0c01 
…g simple names in alerts

Closes GH-1799
@Vankka Vankka closed this Jul 23, 2025
@granny granny deleted the feat/alerts-fully-qualified-class-names branch July 25, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@granny granny Awaiting requested review from granny

@Scarsz Scarsz Awaiting requested review from Scarsz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alerts don't work on Paper 1.21.5+

3 participants

@Vankka @ANutley @OakLoaf