-
Notifications
You must be signed in to change notification settings - Fork 221
Fix config_pes.xml for B compsets. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedwards4b I removed the extra match and rechecked the different B compsets. |
jedwards4b
approved these changes
Oct 15, 2018
fischer-ncar
pushed a commit
that referenced
this pull request
Mar 3, 2020
The previous implementation, relying on the lower-level subprocess.Popen, was hanging when trying to get the status of a git repository with many changed files (see ESMCI/manage_externals#113). It seems that the problem was that subprocess.Popen buffers output, and we would need to write some extra code to periodically clear the output buffer. This seemed tricky to get right, so I have backed up to using the higher-level subprocess.check_output, as we did prior to ESMCI/manage_externals#81. I am using a new method to detect hangs and print a useful message (which was the point of PR #81), based on threading.Timer. I can't figure out a way to kill the subprocess when it appears to be hanging, but at least we can notify the user of this possible problem. This commit brings this part of the code back to how it was prior to d6423c6, except now we have a hang-detection timer. As a side-benefit, it appears that this change speeds up the unit and system tests, based on a few trial runs before and after this change. (This is probably due to the removal of the 0.02 sec delay associated with the previous subprocess.Popen implementation.)
fischer-ncar
pushed a commit
that referenced
this pull request
Mar 3, 2020
Fix hangs when a subcommand has a lot of output. Rework execute_subprocess timeout handling to prevent hangs The previous implementation, relying on the lower-level subprocess.Popen, was hanging when trying to get the status of a git repository with many changed files (see #113). It seems that the problem was that subprocess.Popen buffers output, and we would need to write some extra code to periodically clear the output buffer. This seemed tricky to get right, so I have backed up to using the higher-level subprocess.check_output, as we did prior to #81. I am using a new method to detect hangs and print a useful message (which was the point of PR #81), based on threading.Timer. I can't figure out a way to kill the subprocess when it appears to be hanging, but at least we can notify the user of this possible problem. This commit brings this part of the code back to how it was prior to d6423c6, except now we have a hang-detection timer. As a side-benefit, it appears that this change speeds up the unit and system tests, based on a few trial runs before and after this change. (This is probably due to the removal of the 0.02 sec delay associated with the previous subprocess.Popen implementation.) User interface changes?: No Fixes #113 (Timeout when getting status from a git repository with many changes) Testing: test removed: none unit tests: pass system tests: pass manual testing: (1) Tested the problem reported in #113 by putting a ton of changes in components/clm (changing permissions on all files, and adding about 7000 files in a testmods directory). The original hung, this version succeeded quickly. (2) Tested the problem reported in #79 and fixed in #81 (because this PR undoes the changes from #81): I tested with authentication required (on hobart, by pointing to the NGEET fates repo): I changed the timeout to 10 seconds, ran 'manage_externals/checkout_externals clm', and reviewed the printed message. It looks like this, after about 10 seconds: Checking out externals: fates, Username for 'https://github.com': Command 'git clone --quiet https://github.com/NGEET/fates fates' from directory /scratch/cluster/sacks/cesm/components/clm/src has taken 10 seconds. It may be hanging. The command will continue to run, but you may want to abort manage_externals with ^C and investigate. A possible cause of hangs is when svn or git require authentication to access a private repository. On some systems, svn and git requests for authentication information will not be displayed to the user. In this case, the program will appear to hang. Ensure you can run svn and git manually and access all repositories without entering your authentication information.
RafaPedroFernandez
pushed a commit
to RafaPedroFernandez/CESM
that referenced
this pull request
May 31, 2024
cam6_2_015: Update externals, update baseline directories.
jedwards4b
added a commit
to jedwards4b/cesm
that referenced
this pull request
Oct 22, 2025
d4ebd39 Bump to 1.0.3 f4d1647 Merge pull request ESCOMP#85 from nusbaume/hash_fetch 5ae52f6 Fetch full history if 'fxtag' is a hash. 22026d2 Merge pull request ESCOMP#81 from ESMCI/fxtag_documentation_update 1ab63bc update doc to correct fxtag git-subtree-dir: .lib/git-fleximod git-subtree-split: d4ebd3998c342453525ad077fa36cc979badb882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config_pes.xml for B compset matches not having a cam modifier was left out of PR #80.
User interface changes?: No
[ If yes, describe what changed, and steps taken to ensure backward compatibilty ]
Fixes: [Github issue #s] And brief description of each issue.
Testing:
unit tests:
system tests:
manual testing: B1850, BW1850, B1PCT, BW1PCT, BCO2x4, and BWCO2x4 on cheyenne,
compared env_mach_pes.xml.