Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix VM init stack offset #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Fix VM init stack offset #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe75af0
Fix init offset for stack start.
adlerjohn Feb 28, 2021
e86034d
Typo fix.
adlerjohn Feb 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/protocol/tx_validity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Once a transaction is seen, it goes through several stages of validation, in thi

## VM Precondition Validity Rules

This section defines _vm precondition validity rules_ for transactions: the bare minimum required to accept an unconfirmed transaction into a mempool, and preconditions that the VM assumes to hold prior to execution. Chains of unconfirmed transactions are omitted.
This section defines _VM precondition validity rules_ for transactions: the bare minimum required to accept an unconfirmed transaction into a mempool, and preconditions that the VM assumes to hold prior to execution. Chains of unconfirmed transactions are omitted.

The validity rules assuming sequential transaction validation for side effects (i.e. state changes). However, by construction, transactions with different access lists can be validated in parallel. Transactions with overlapping access lists must be validated and placed in blocks in topological order.

Expand Down
2 changes: 1 addition & 1 deletion specs/vm/main.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ To initialize the VM, the following is pushed on the stack sequentially:
1. The [transaction, serialized](../protocol/tx_format.md).

Then the following registers are initialized (without explicit initialization, all registers are initialized to zero):
1. `$ssp = 32 + size(tx))`: the writable stack area starts immediately after the transaction in memory.
1. `$ssp = 32 + MAX_INPUTS*(32+8) + size(tx))`: the writable stack area starts immediately after the transaction in memory.
1. `$sp = $sp`: writable stack area is empty to start.
1. `$fp = VM_MAX_RAM - 1`: the heap area begins at the top.
1. `$hp = $fp`: heap area is empty to start.
Expand Down