Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change AbstractCell members to properties #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 23, 2025
Merged

Change AbstractCell members to properties #385

merged 22 commits into from
Oct 23, 2025

Conversation

@schnellerhase
Copy link
Contributor

@schnellerhase schnellerhase commented Jun 25, 2025 •
edited
Loading

@schnellerhase schnellerhase changed the title Change AbstractCell members to properties Change AbstractCell members to properties Sep 13, 2025
This was referenced Sep 13, 2025
Merged
Merged
@schnellerhase schnellerhase marked this pull request as ready for review September 14, 2025 09:13
@dham
Copy link
Collaborator

dham commented Sep 24, 2025

Can this please land after we do the October Firedrake release as it's an API change and we don't want to drop it into our release at short notice.

@jorgensd
Copy link
Member

Can this please land after we do the October Firedrake release as it's an API change and we don't want to drop it into our release at short notice.

That is fine with me. This is nothing crucial for the functionality of ufl, so it shouldn’t me merged right before a release.

@schnellerhase
Copy link
Contributor Author

No reason to rush this 👍

@schnellerhase
Copy link
Contributor Author

Good to move on this given the past release?

@connorjward
Copy link
Contributor

Good to move on this given the past release?

Yeah I guess so. Can this happen after Monday next week? That gives me a day to get a Firedrake PR ready.

connorjward added a commit to firedrakeproject/fiat that referenced this pull request Oct 6, 2025
@connorjward
Adapt to UFL API changing methods to properties
72d2c18 
See FEniCS/ufl#385.
@connorjward connorjward mentioned this pull request Oct 6, 2025
Merged
connorjward added a commit to firedrakeproject/firedrake that referenced this pull request Oct 6, 2025
@connorjward
Adapt to UFL changing some methods to properties
bcb850c 
See FEniCS/ufl#385.
@connorjward connorjward mentioned this pull request Oct 6, 2025
Merged
@connorjward
Copy link
Contributor

I have prepared some PRs for Firedrake for this but I've observed that some inconsistencies still remain in UFL. For instance

ufl/ufl/differentiation.py

Line 321 in dd46e97

dim = extract_unique_domain(f, expand_mesh_sequence=False).topological_dimension()
is throwing an error for us as it isn't changed as part of this PR.

Could I just push fixes for these to this branch? (Assuming I have the right permissions)

@connorjward
Copy link
Contributor

I wasn't able to. See #427. This isn't necessarily all of them.

@connorjward connorjward mentioned this pull request Oct 6, 2025
Merged
connorjward and others added 2 commits October 6, 2025 18:22
@connorjward
Replace more methods with properties (#427)
cba6c85 
* Replace more examples

* Another one

* Another one
@schnellerhase
Change branches
69f8f83
schnellerhase
schnellerhase commented Oct 6, 2025
View reviewed changes
@schnellerhase
Copy link
Contributor Author

Green lighted by @connorjward - good to move.

@jorgensd jorgensd added this pull request to the merge queue Oct 23, 2025
@schnellerhase schnellerhase removed this pull request from the merge queue due to a manual request Oct 23, 2025
@schnellerhase schnellerhase added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 2ddbe85 Oct 23, 2025
18 of 21 checks passed
@schnellerhase schnellerhase deleted the schnellerhase/fix_169 branch October 23, 2025 11:40
ksagiyam pushed a commit to firedrakeproject/fiat that referenced this pull request Oct 23, 2025
@connorjward
Adapt to UFL API changing methods to properties (#192)
4472a36 
* Adapt to UFL API changing methods to properties

See FEniCS/ufl#385.
ksagiyam pushed a commit to firedrakeproject/firedrake that referenced this pull request Oct 24, 2025
@connorjward
Adapt to UFL changing some methods to properties (#4629)
bb8447a 
* Adapt to UFL changing some methods to properties

See FEniCS/ufl#385.
@jorgensd jorgensd mentioned this pull request Oct 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscroggs mscroggs Awaiting requested review from mscroggs

@jorgensd jorgensd Awaiting requested review from jorgensd

Assignees

No one assigned

Labels

housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make methods into properties in AbstractCell

4 participants

@schnellerhase @dham @jorgensd @connorjward