Handle error in viewflif gracefully #413
Conversation
|
I can still reproduce with this changeset, still crashing. :/ |
|
@matthiaskrgr Does it crash always or sometimes? There is a small chance that there is a race condition. But if it is crashing always then there is some other problem, because it is not crashing even once for me, with this change. Just to be sure, can you do a |
|
I freshly cloned the UprootStaging repo and checked out the branch for testing so there is no need for a clean build. Hmm, it looks like there is a very high probability of crashing on my sys. With the crash command, it only did NOT crash one in 30 times. |
|
@matthiaskrgr Hmm, there is probably some other problem which is compounding with the issue that this PR fixes. I will remove the |
|
Ok |
This was originally created to address #412
In my system before the fix,
viewflifgoes into an infinite loop (becauseddoesn't become NULL). There is no seg fault. After these changes,viewflifcloses gracefully.I thought the seg fault seen by @matthiaskrgr would go away too, but probably that's a different issue (see comments below).