Added decoding directly from a FILE* pointer to the API #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oops, didn't include stdio. Lemme add that and repull. |
… to the API Added #includes for stdio.h
Contributor
Author
|
Squashed commits. |
Member
|
Thanks! Useful indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is particularly useful because not all FILE* pointers were created from fopen to point to files on the hard drive. Some could be created by routines such as
tmpfile(3)oropen_memstream(3)and currently FLIF has no way of decoding them without buffering them into memory and using flif_decoder_decode_memory. This adds flif_decoder_decode_filepointer to the exported API. The caller still needs to pass a filename, but the filename can be any non-NULL string, because it's only used for the decoder to print error messages. A rich reader can give it a real name or a dummy name like "FilePointer."