Replace global variables pixel_progress etc with Progress class #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d61a59 to
0fbe20f
Compare
|
Thank you @mshepcar for providing this patch! 👍 It fixed the problem I was having when trying to decode multiple FLIF images in parallel using threads (images came out monochrome for some reason). Makes me wonder why it has not yet been merged to master. Are there any known problems? |
4 tasks
|
Ping, this MR is one blocking point for adoption in a Python lib |
|
Please note that FLIF is superseded by FUIF, which itself is superseded by JPEG-XL. |
|
Oh nice |
Member
|
Thanks for the improvement - sorry to have been so negligent in maintaining FLIF. Like @bjorn3 said, FLIF is superseded by JPEG XL. So any project currently using FLIF should consider switching to libjxl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced four global variables with a class that is passed around to fix issues when encoding/decoding from multiple threads as per issue #517