explicit SRv6 address configurable per address family #19088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b216cb7 to
55646b2
Compare
cscarpitta
reviewed
Jun 26, 2025
tests/topotests/bgp_srv6_sid_explicit/test_bgp_srv6_sid_explicit.py
Outdated
Show resolved
Hide resolved
55646b2 to
7673bfc
Compare
Member
Author
|
ci:rerun |
5575e1a to
5bc1cca
Compare
Member
Author
|
ci:rerun |
5bc1cca to
cc9a1f0
Compare
ahsalam
approved these changes
Jul 1, 2025
ahsalam
left a comment
There was a problem hiding this comment.
LGTM. Thanks for extending the explicit SID allocation functionality per address family
ton31337
reviewed
Jul 1, 2025
cc9a1f0 to
ced440e
Compare
Member
Author
|
ci:rerun |
1 similar comment
Member
Author
|
ci:rerun |
The mode change algorithm is complex, more readability is needed. Simplify the algorithm by splitting into multiple if conditions. Signed-off-by: Philippe Guibert <[email protected]>
Add support for bgp to use explicit SRv6 SID per address-family. The following command is available under ipv4/ipv6 unicast address family node: > sid vpn export explicit X:X::X:X" If SRv6 SID manager allocates the explicit SID successfully, then BGP will advertise it. Signed-off-by: Philippe Guibert <[email protected]>
The following trace may be visible when configuring explicit mode > 2025/06/24 18:14:50.382809 BGP: [H2QJF-E1VQM] ensure_vrf_tovpn_sid_per_af: explicit-mode seleted without sid value. Fix the typo: selected instead of seleted. Signed-off-by: Philippe Guibert <[email protected]>
It should be forbidden to both configure per-address family sid, and per-vrf sid vpn explicit config. Fixes: 7169055 ("bgpd: Add support for BGP to use SRv6 SID in an explicit way") Signed-off-by: Philippe Guibert <[email protected]>
Move some utility functions used to compare expected outputs, outside of the functions. This is a preparatory commit before hosting explicit per-address family testing. Apply black style. Signed-off-by: Philippe Guibert <[email protected]>
Add a test that controls whether the sid per-vrf unconfiguraiton flushes the SIDs from the srv6 sid table. Signed-off-by: Philippe Guibert <[email protected]>
Add a topotest for bgp explicit srv6 sid per address family. Signed-off-by: Philippe Guibert <[email protected]>
Add documentation about sid vpn export command, under bgp address-family. Signed-off-by: Philippe Guibert <[email protected]>
ced440e to
4e26d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the ability to configure 'sid vpn explicit' 128 bit ipv6 address per address family.