-
-
Couldn't load subscription status.
- Fork 101
Fix talker.handle docs to use stack trace before error message #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated documentation for talker.handle to reflect correct parameter order, placing stack trace before message. Class diagram for updated talker.handle documentationclassDiagram
class Talker {
+handle(Object exception, StackTrace? stackTrace, String? msg)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
==========================================
- Coverage 98.63% 90.97% -7.66%
==========================================
Files 3 13 +10
Lines 146 266 +120
==========================================
+ Hits 144 242 +98
- Misses 2 24 +22 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
|
Hello @Ali-Toosi ! |
The code docs for
talker.handleincorrectly show the error message argument before the stack trace. This PR fixes that.Summary by Sourcery
Fix parameter order in talker.handle documentation to place the stack trace argument before the error message
Documentation: