Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Exception and StackTrace is ignored for logs #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix Exception and StackTrace is ignored for logs #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff7c52d
fix: :construction: Add exception and stack trace to Talker class
qwadrox Mar 5, 2024
c59a93a
Update dependencies in pubspec.lock file
qwadrox Mar 5, 2024
e044ef3
test: :test_tube: Add tests for observer's log methods
qwadrox Mar 5, 2024
2f75b9d
style: :lipstick: format code
qwadrox Mar 5, 2024
450129e
refactor: :recycle: Update exception type in TalkerData class and Tal…
qwadrox Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 46 additions & 22 deletions examples/shop_app_example/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ packages:
dependency: transitive
description:
name: collection
sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
url: "https://pub.dev"
source: hosted
version: "1.17.2"
version: "1.18.0"
cross_file:
dependency: transitive
description:
Expand Down Expand Up @@ -223,7 +223,7 @@ packages:
sha256: "2aa08ce0341cc9b354a498388e30986515406668dbcc4f7c950c3e715496693b"
url: "https://pub.dev"
source: hosted
version: "4.0.3"
version: "4.0.2"
js:
dependency: transitive
description:
Expand All @@ -232,6 +232,30 @@ packages:
url: "https://pub.dev"
source: hosted
version: "0.6.7"
leak_tracker:
dependency: transitive
description:
name: leak_tracker
sha256: "78eb209deea09858f5269f5a5b02be4049535f568c07b275096836f01ea323fa"
url: "https://pub.dev"
source: hosted
version: "10.0.0"
leak_tracker_flutter_testing:
dependency: transitive
description:
name: leak_tracker_flutter_testing
sha256: b46c5e37c19120a8a01918cfaf293547f47269f7cb4b0058f21531c2465d6ef0
url: "https://pub.dev"
source: hosted
version: "2.0.1"
leak_tracker_testing:
dependency: transitive
description:
name: leak_tracker_testing
sha256: a597f72a664dbd293f3bfc51f9ba69816f84dcd403cdac7066cb3f6003f3ab47
url: "https://pub.dev"
source: hosted
version: "2.0.1"
lints:
dependency: transitive
description:
Expand All @@ -244,26 +268,26 @@ packages:
dependency: transitive
description:
name: matcher
sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
url: "https://pub.dev"
source: hosted
version: "0.12.16"
version: "0.12.16+1"
material_color_utilities:
dependency: transitive
description:
name: material_color_utilities
sha256: "9528f2f296073ff54cb9fee677df673ace1218163c3bc7628093e7eed5203d41"
sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
url: "https://pub.dev"
source: hosted
version: "0.5.0"
version: "0.8.0"
meta:
dependency: transitive
description:
name: meta
sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04
url: "https://pub.dev"
source: hosted
version: "1.9.1"
version: "1.11.0"
mime:
dependency: transitive
description:
Expand All @@ -284,10 +308,10 @@ packages:
dependency: transitive
description:
name: path
sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
url: "https://pub.dev"
source: hosted
version: "1.8.3"
version: "1.9.0"
path_provider:
dependency: transitive
description:
Expand Down Expand Up @@ -401,18 +425,18 @@ packages:
dependency: transitive
description:
name: stack_trace
sha256: c3c7d8edb15bee7f0f74debd4b9c5f3c2ea86766fe4178eb2a18eb30a0bdaed5
sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
url: "https://pub.dev"
source: hosted
version: "1.11.0"
version: "1.11.1"
stream_channel:
dependency: transitive
description:
name: stream_channel
sha256: "83615bee9045c1d322bbbd1ba209b7a749c2cbcdcb3fdd1df8eb488b3279c1c8"
sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
url: "https://pub.dev"
source: hosted
version: "2.1.1"
version: "2.1.2"
string_scanner:
dependency: transitive
description:
Expand Down Expand Up @@ -468,10 +492,10 @@ packages:
dependency: transitive
description:
name: test_api
sha256: "75760ffd7786fffdfb9597c35c5b27eaeec82be8edfb6d71d32651128ed7aab8"
sha256: "5c2f730018264d276c20e4f1503fd1308dfbbae39ec8ee63c5236311ac06954b"
url: "https://pub.dev"
source: hosted
version: "0.6.0"
version: "0.6.1"
typed_data:
dependency: transitive
description:
Expand Down Expand Up @@ -560,14 +584,14 @@ packages:
url: "https://pub.dev"
source: hosted
version: "2.1.4"
web:
vm_service:
dependency: transitive
description:
name: web
sha256: dc8ccd225a2005c1be616fe02951e2e342092edf968cf0844220383757ef8f10
name: vm_service
sha256: b3d56ff4341b8f182b96aceb2fa20e3dcb336b9f867bc0eafc0de10f1048e957
url: "https://pub.dev"
source: hosted
version: "0.1.4-beta"
version: "13.0.0"
win32:
dependency: transitive
description:
Expand All @@ -585,5 +609,5 @@ packages:
source: hosted
version: "1.0.4"
sdks:
dart: ">=3.1.0 <4.0.0"
dart: ">=3.2.0-0 <4.0.0"
flutter: ">=3.13.0"
2 changes: 1 addition & 1 deletion packages/talker/lib/src/models/talker_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class TalkerData {
/// {@template talker_data_exception}
/// [Exception?] [exception] - exception if it happened
/// {@endtemplate}
final Exception? exception;
final Object? exception;

/// {@template talker_data_error}
/// [Error?] [error] - error if it happened
Expand Down
2 changes: 2 additions & 0 deletions packages/talker/lib/src/talker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,8 @@ class Talker {
key: type.key,
message?.toString() ?? '',
title: settings.getTitleByLogType(type),
exception: exception,
stackTrace: stackTrace,
pen: settings.getAnsiPenByLogType(type),
logLevel: logLevel,
);
Expand Down
122 changes: 122 additions & 0 deletions packages/talker/test/talker_observer_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,126 @@ void main() {
expect(_exceptionsStore, isEmpty);
});
});

group('Test observer\'s log method invoked with the correct log', () {
late Talker talker;
final mockObserver = MockTalkerObserver();

setUp(() {
talker = Talker(observer: mockObserver);
talker.cleanHistory();
_logsStore.clear();
_errorsStore.clear();
_exceptionsStore.clear();
});

test('info method logs correct message, exception, and stack trace', () {
final exception = "Test exception";
final stack = StackTrace.fromString('Test stack');
final logMessage = 'log';
talker.info(logMessage, exception, stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});

test('error method logs correct message, exception, and stack trace', () {
final exception = "Test exception";
final stack = StackTrace.fromString("Test stack");
final logMessage = 'log';
talker.error(logMessage, exception, stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});

test('verbose method logs correct message, exception, and stack trace', () {
final exception = "Test exception";
final stack = StackTrace.fromString("Test stack");
final logMessage = 'log';
talker.verbose(logMessage, exception, stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});

test('warning method logs correct message, exception, and stack trace', () {
final exception = "Test exception";
final stack = StackTrace.fromString("Test stack");
final logMessage = 'log';
talker.warning(logMessage, exception, stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});

test('debug method logs correct message, exception, and stack trace', () {
final exception = "Test exception";
final stack = StackTrace.fromString("Test stack");
final logMessage = 'log';
talker.debug(logMessage, exception, stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});

test('critical method logs correct message, exception, and stack trace',
() {
final exception = "Test exception";
final stack = StackTrace.fromString("Test stack");
final logMessage = 'log';
talker.critical(logMessage, exception, stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});

test(
'custom log level method logs correct message, exception, and stack trace',
() {
final exception = "Test exception";
final stack = StackTrace.fromString("Test stack");
final logMessage = 'log';
talker.log(logMessage,
logLevel: LogLevel.debug, exception: exception, stackTrace: stack);

expect(_logsStore.last.message, equals(logMessage));
expect(_logsStore.last.exception.toString(), equals(exception));
expect(_logsStore.last.stackTrace, equals(stack));

expect(_logsStore, isNotEmpty);
expect(_errorsStore, isEmpty);
expect(_exceptionsStore, isEmpty);
});
});
}
Loading