Show full data of Bloc logs in Flutter Talker #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
===========================================
+ Coverage 98.73% 100.00% +1.26%
===========================================
Files 28 3 -25
Lines 555 90 -465
===========================================
- Hits 548 90 -458
+ Misses 7 0 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Frezyx
approved these changes
May 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Flutter Talker Screen by ensuring that the full state data from Bloc logs is included in the log messages. Key changes include:
- Updating BlocStateLog and BlocChangeLog constructors to pass full state information via the super call.
- Removing duplicate state information writing from the log formatting methods.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This pull request fixes a minor bug in the Flutter Talker Screen; basically since the
BlocStateLogand theBlocChangeLogdidn't callsuper()with all the data they provide, only part of the information was getting into the message field of theTalkerLog, resulting in only part of data being shown in the actual application, while the full data was printed in debug console.Before:
After:
