Add support WASM for Flutter Web #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frezyx
requested changes
Jan 3, 2025
Comment on lines
7
to
26
| Future<R?> runTalkerZonedGuarded<R>(Talker talker, R Function() body, | ||
| void Function(Object error, StackTrace stack) onError, | ||
| {Map<Object?, Object?>? zoneValues, | ||
| ZoneSpecification? zoneSpecification, | ||
| bool catchFlutterErrors = true}) async { | ||
| _setupErrorHooks(talker, catchFlutterErrors: catchFlutterErrors); | ||
| return runZonedGuarded<R>(body, (dynamic error, StackTrace stackTrace) { | ||
| onError(error, stackTrace); | ||
| _reportError(error, stackTrace, talker); | ||
| }, zoneValues: zoneValues, zoneSpecification: zoneSpecification); | ||
| } | ||
|
|
||
| void _reportError( | ||
| dynamic error, | ||
| dynamic stackTrace, | ||
| Talker talker, { | ||
| FlutterErrorDetails? errorDetails, | ||
| }) async { | ||
| talker.error("Unhandled Exception", error, stackTrace); | ||
| } |
There was a problem hiding this comment.
I think this code is same for io and web realizations
Can we separate only _setupErrorHooks method to avoid repeating ща the code?
There was a problem hiding this comment.
i had to expose everything, so it can be used by the other files, i hope thats okay
i couldnt get it to work without exposing them
|
Hello @abdelaziz-mahdy ! Can you fix review issues before we merge this PR ? |
Frezyx
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should fix #301, but i dont have a way to be 100 % sure, since it didnt fail to compile for me without it