Remove deprecated dart:html #337
Conversation
…ted & minor improving
|
Hello @Mooyeee ! Please fix analyzer issues before we merge this |
|
@Frezyx I can do it if you want, but the analyzer failed because of info messages that weren't introduced by this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
===========================================
+ Coverage 98.44% 100.00% +1.55%
===========================================
Files 28 8 -20
Lines 579 66 -513
===========================================
- Hits 570 66 -504
+ Misses 9 0 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @Mooyeee ! |
|
Hello, |
Hello!
I rewrote the web logger printer in order to remove the dependency on the deprecated dart:html library.
I also made the already refactored download web logs implementation the default when on web (since jsinterop is a full substitution to dart:html).
Also, for the download, I avoided adding an element to the dom with a random name and instead created an anonymous AnchorElement in place and then removed after downloading the logs.
I have a question though: why the flutter logger doesn't use the default printer but instead uses print and flutter default log? (btw kIsWeb would be false when compiling to wasm, there is kIsWasm for that)
In my local implementation I tried using the default printer and it works as expected so I was wondering if there are some corner cases I'm not considering.
Kind regards,
Mooyeee