-
-
Couldn't load subscription status.
- Fork 101
Add prepare release bash scripts #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request introduces three bash scripts ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frezyx - I've reviewed your changes - here's some feedback:
- Consider adding error checking after calling sub-scripts in
prepare_release.shto halt execution if a step fails. - The
sed -i ''command inupdate_version.shmight not be portable across different operating systems (e.g., Linux vs. macOS).
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| input_file="$SCRIPT_DIR/version.txt" | ||
|
|
||
| # Чтение строк | ||
| old_version=$(sed -n '1p' "$input_file" | xargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Check that version.txt exists before processing.
This will produce a clearer error if version.txt is missing and make the script more robust.
| input_file="$SCRIPT_DIR/version.txt" | |
| # Чтение строк | |
| old_version=$(sed -n '1p' "$input_file" | xargs) | |
| input_file="$SCRIPT_DIR/version.txt" | |
| # Check if version.txt exists before processing | |
| if [[ ! -f "$input_file" ]]; then | |
| echo "❌ $input_file does not exist." | |
| exit 1 | |
| fi | |
| # Чтение строк | |
| old_version=$(sed -n '1p' "$input_file" | xargs) |
Summary by Sourcery
Add bash scripts to automate release preparation and version management
New Features:
Chores: